Improve rum injection output stream #9107

amarziali · 2025-07-04T15:30:16Z

What Does This Do

Implement bulk write (FilteredOutputStream does not hence looping on each byte).

Also did some bench. JMH shows one increment of 30% to write a google home page while looking for</head> and injecting a content. However this can be justified since this feature is obviously introducing an impact (It's not enabled by default).
On the other hand, the algorithm can maybe be optimized but I'm lacking of ideas today

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-04T15:59:52Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/better-piped-injector
git_commit_date	1751873095	1751875795
git_commit_sha	`bbdc0b7`	`24c817e`
release_version	1.51.0-SNAPSHOT~bbdc0b7f15	1.51.0-SNAPSHOT~24c817e49c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751877562	1751877562
ci_job_id	1015336825	1015336825
ci_pipeline_id	69742479	69742479
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-njl7j1wn 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-njl7j1wn 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.892 ms) : 0, 994892
Total [baseline] (8.632 s) : 0, 8631568
Agent [candidate] (1.005 s) : 0, 1005499
Total [candidate] (8.605 s) : 0, 8604751
section iast
Agent [baseline] (1.142 s) : 0, 1142026
Total [baseline] (9.282 s) : 0, 9282207
Agent [candidate] (1.14 s) : 0, 1140465
Total [candidate] (9.348 s) : 0, 9348341

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	994.892 ms	-
Agent	iast	1.142 s	147.135 ms (14.8%)
Total	tracing	8.632 s	-
Total	iast	9.282 s	650.639 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.005 s	-
Agent	iast	1.14 s	134.966 ms (13.4%)
Total	tracing	8.605 s	-
Total	iast	9.348 s	743.591 ms (8.6%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.242 ms) : 0, 687242
BytebuddyAgent [candidate] (694.472 ms) : 0, 694472
GlobalTracer [baseline] (241.685 ms) : 0, 241685
GlobalTracer [candidate] (244.23 ms) : 0, 244230
AppSec [baseline] (30.212 ms) : 0, 30212
AppSec [candidate] (30.629 ms) : 0, 30629
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.152 ms) : 0, 6152
Remote Config [baseline] (678.767 µs) : 0, 679
Remote Config [candidate] (695.061 µs) : 0, 695
Telemetry [baseline] (8.246 ms) : 0, 8246
Telemetry [candidate] (8.314 ms) : 0, 8314
section iast
BytebuddyAgent [baseline] (814.481 ms) : 0, 814481
BytebuddyAgent [candidate] (812.068 ms) : 0, 812068
GlobalTracer [baseline] (234.295 ms) : 0, 234295
GlobalTracer [candidate] (234.937 ms) : 0, 234937
AppSec [baseline] (28.999 ms) : 0, 28999
AppSec [candidate] (30.642 ms) : 0, 30642
Debugger [baseline] (6.686 ms) : 0, 6686
Debugger [candidate] (5.834 ms) : 0, 5834
Remote Config [baseline] (597.094 µs) : 0, 597
Remote Config [candidate] (594.805 µs) : 0, 595
Telemetry [baseline] (8.113 ms) : 0, 8113
Telemetry [candidate] (8.112 ms) : 0, 8112
IAST [baseline] (27.989 ms) : 0, 27989
IAST [candidate] (27.441 ms) : 0, 27441

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (996.719 ms) : 0, 996719
Total [baseline] (10.723 s) : 0, 10722938
Agent [candidate] (997.635 ms) : 0, 997635
Total [candidate] (10.689 s) : 0, 10688610
section appsec
Agent [baseline] (1.177 s) : 0, 1177101
Total [baseline] (10.785 s) : 0, 10785191
Agent [candidate] (1.179 s) : 0, 1178803
Total [candidate] (10.753 s) : 0, 10752758
section iast
Agent [baseline] (1.144 s) : 0, 1144363
Total [baseline] (11.019 s) : 0, 11019161
Agent [candidate] (1.152 s) : 0, 1152352
Total [candidate] (10.945 s) : 0, 10944949
section profiling
Agent [baseline] (1.246 s) : 0, 1245585
Total [baseline] (10.958 s) : 0, 10958152
Agent [candidate] (1.246 s) : 0, 1246284
Total [candidate] (11.059 s) : 0, 11058937

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	996.719 ms	-
Agent	appsec	1.177 s	180.382 ms (18.1%)
Agent	iast	1.144 s	147.644 ms (14.8%)
Agent	profiling	1.246 s	248.866 ms (25.0%)
Total	tracing	10.723 s	-
Total	appsec	10.785 s	62.253 ms (0.6%)
Total	iast	11.019 s	296.223 ms (2.8%)
Total	profiling	10.958 s	235.215 ms (2.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.635 ms	-
Agent	appsec	1.179 s	181.168 ms (18.2%)
Agent	iast	1.152 s	154.717 ms (15.5%)
Agent	profiling	1.246 s	248.65 ms (24.9%)
Total	tracing	10.689 s	-
Total	appsec	10.753 s	64.148 ms (0.6%)
Total	iast	10.945 s	256.339 ms (2.4%)
Total	profiling	11.059 s	370.327 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.957 ms) : 0, 687957
BytebuddyAgent [candidate] (688.922 ms) : 0, 688922
GlobalTracer [baseline] (242.654 ms) : 0, 242654
GlobalTracer [candidate] (242.543 ms) : 0, 242543
AppSec [baseline] (30.255 ms) : 0, 30255
AppSec [candidate] (30.371 ms) : 0, 30371
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (685.69 µs) : 0, 686
Remote Config [candidate] (687.212 µs) : 0, 687
Telemetry [baseline] (8.224 ms) : 0, 8224
Telemetry [candidate] (8.232 ms) : 0, 8232
section appsec
BytebuddyAgent [baseline] (711.473 ms) : 0, 711473
BytebuddyAgent [candidate] (714.012 ms) : 0, 714012
GlobalTracer [baseline] (235.804 ms) : 0, 235804
GlobalTracer [candidate] (234.645 ms) : 0, 234645
AppSec [baseline] (171.306 ms) : 0, 171306
AppSec [candidate] (171.468 ms) : 0, 171468
Debugger [baseline] (5.77 ms) : 0, 5770
Debugger [candidate] (5.77 ms) : 0, 5770
Remote Config [baseline] (606.033 µs) : 0, 606
Remote Config [candidate] (597.463 µs) : 0, 597
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (8.07 ms) : 0, 8070
IAST [baseline] (23.199 ms) : 0, 23199
IAST [candidate] (23.342 ms) : 0, 23342
section iast
BytebuddyAgent [baseline] (815.323 ms) : 0, 815323
BytebuddyAgent [candidate] (821.649 ms) : 0, 821649
GlobalTracer [baseline] (235.035 ms) : 0, 235035
GlobalTracer [candidate] (236.425 ms) : 0, 236425
AppSec [baseline] (30.739 ms) : 0, 30739
AppSec [candidate] (30.314 ms) : 0, 30314
Debugger [baseline] (5.887 ms) : 0, 5887
Debugger [candidate] (6.778 ms) : 0, 6778
Remote Config [baseline] (591.311 µs) : 0, 591
Remote Config [candidate] (592.141 µs) : 0, 592
Telemetry [baseline] (8.197 ms) : 0, 8197
Telemetry [candidate] (8.128 ms) : 0, 8128
IAST [baseline] (27.533 ms) : 0, 27533
IAST [candidate] (27.444 ms) : 0, 27444
section profiling
ProfilingAgent [baseline] (103.424 ms) : 0, 103424
ProfilingAgent [candidate] (104.546 ms) : 0, 104546
BytebuddyAgent [baseline] (678.203 ms) : 0, 678203
BytebuddyAgent [candidate] (677.304 ms) : 0, 677304
GlobalTracer [baseline] (362.092 ms) : 0, 362092
GlobalTracer [candidate] (363.216 ms) : 0, 363216
AppSec [baseline] (31.789 ms) : 0, 31789
AppSec [candidate] (31.71 ms) : 0, 31710
Debugger [baseline] (11.275 ms) : 0, 11275
Debugger [candidate] (11.263 ms) : 0, 11263
Remote Config [baseline] (675.042 µs) : 0, 675
Remote Config [candidate] (682.035 µs) : 0, 682
Telemetry [baseline] (9.56 ms) : 0, 9560
Telemetry [candidate] (8.929 ms) : 0, 8929
Profiling [baseline] (103.448 ms) : 0, 103448
Profiling [candidate] (104.571 ms) : 0, 104571

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/better-piped-injector
git_commit_date	1751873095	1751875795
git_commit_sha	`bbdc0b7`	`24c817e`
release_version	1.51.0-SNAPSHOT~bbdc0b7f15	1.51.0-SNAPSHOT~24c817e49c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751877450	1751877450
ci_job_id	1015336826	1015336826
ci_pipeline_id	69742479	69742479
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-ivh065d3 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-ivh065d3 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+258.199µs; +662.871µs] or [+2.515%; +6.458%]	unstable [-68.735op/s; +29.922op/s] or [-15.179%; +6.608%]	10.725ms	433.406op/s	10.264ms	452.812op/s
scenario:load:petclinic:appsec:high_load	worse [+2.457ms; +3.356ms] or [+5.303%; +7.244%]	unstable [-13.034op/s; +1.134op/s] or [-12.906%; +1.123%]	49.233ms	95.037op/s	46.326ms	100.987op/s
scenario:load:petclinic:no_agent:high_load	worse [+1.772ms; +2.414ms] or [+4.970%; +6.770%]	unstable [-16.136op/s; +1.661op/s] or [-12.313%; +1.268%]	37.755ms	123.812op/s	35.661ms	131.050op/s
scenario:load:petclinic:tracing:high_load	worse [+0.964ms; +1.768ms] or [+2.243%; +4.115%]	unstable [-11.114op/s; +4.339op/s] or [-10.207%; +3.985%]	44.331ms	105.500op/s	42.965ms	108.888op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.661 ms) : 35376, 35946
.   : milestone, 35661,
appsec (46.326 ms) : 45932, 46721
.   : milestone, 46326,
code_origins (45.591 ms) : 45197, 45984
.   : milestone, 45591,
iast (44.633 ms) : 44237, 45030
.   : milestone, 44633,
profiling (49.985 ms) : 49526, 50443
.   : milestone, 49985,
tracing (42.965 ms) : 42601, 43329
.   : milestone, 42965,
section candidate
no_agent (37.755 ms) : 37444, 38066
.   : milestone, 37755,
appsec (49.233 ms) : 48792, 49673
.   : milestone, 49233,
code_origins (44.8 ms) : 44425, 45175
.   : milestone, 44800,
iast (45.03 ms) : 44642, 45418
.   : milestone, 45030,
profiling (49.933 ms) : 49412, 50454
.   : milestone, 49933,
tracing (44.331 ms) : 43948, 44714
.   : milestone, 44331,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.661 ms [35.376 ms, 35.946 ms]	-
appsec	46.326 ms [45.932 ms, 46.721 ms]	10.665 ms (29.9%)
code_origins	45.591 ms [45.197 ms, 45.984 ms]	9.93 ms (27.8%)
iast	44.633 ms [44.237 ms, 45.03 ms]	8.972 ms (25.2%)
profiling	49.985 ms [49.526 ms, 50.443 ms]	14.323 ms (40.2%)
tracing	42.965 ms [42.601 ms, 43.329 ms]	7.304 ms (20.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.755 ms [37.444 ms, 38.066 ms]	-
appsec	49.233 ms [48.792 ms, 49.673 ms]	11.478 ms (30.4%)
code_origins	44.8 ms [44.425 ms, 45.175 ms]	7.045 ms (18.7%)
iast	45.03 ms [44.642 ms, 45.418 ms]	7.275 ms (19.3%)
profiling	49.933 ms [49.412 ms, 50.454 ms]	12.178 ms (32.3%)
tracing	44.331 ms [43.948 ms, 44.714 ms]	6.576 ms (17.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.352 ms) : 4300, 4404
.   : milestone, 4352,
iast (9.161 ms) : 9010, 9311
.   : milestone, 9161,
iast_FULL (13.981 ms) : 13704, 14258
.   : milestone, 13981,
iast_GLOBAL (10.264 ms) : 10079, 10450
.   : milestone, 10264,
profiling (8.689 ms) : 8555, 8823
.   : milestone, 8689,
tracing (7.439 ms) : 7332, 7547
.   : milestone, 7439,
section candidate
no_agent (4.447 ms) : 4389, 4506
.   : milestone, 4447,
iast (9.174 ms) : 9024, 9324
.   : milestone, 9174,
iast_FULL (14.14 ms) : 13858, 14421
.   : milestone, 14140,
iast_GLOBAL (10.725 ms) : 10535, 10915
.   : milestone, 10725,
profiling (8.6 ms) : 8465, 8735
.   : milestone, 8600,
tracing (7.476 ms) : 7370, 7581
.   : milestone, 7476,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.352 ms [4.3 ms, 4.404 ms]	-
iast	9.161 ms [9.01 ms, 9.311 ms]	4.808 ms (110.5%)
iast_FULL	13.981 ms [13.704 ms, 14.258 ms]	9.629 ms (221.3%)
iast_GLOBAL	10.264 ms [10.079 ms, 10.45 ms]	5.912 ms (135.9%)
profiling	8.689 ms [8.555 ms, 8.823 ms]	4.337 ms (99.7%)
tracing	7.439 ms [7.332 ms, 7.547 ms]	3.087 ms (70.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.447 ms [4.389 ms, 4.506 ms]	-
iast	9.174 ms [9.024 ms, 9.324 ms]	4.727 ms (106.3%)
iast_FULL	14.14 ms [13.858 ms, 14.421 ms]	9.692 ms (217.9%)
iast_GLOBAL	10.725 ms [10.535 ms, 10.915 ms]	6.278 ms (141.2%)
profiling	8.6 ms [8.465 ms, 8.735 ms]	4.153 ms (93.4%)
tracing	7.476 ms [7.37 ms, 7.581 ms]	3.028 ms (68.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/better-piped-injector
git_commit_date	1751873095	1751875795
git_commit_sha	`bbdc0b7`	`24c817e`
release_version	1.51.0-SNAPSHOT~bbdc0b7f15	1.51.0-SNAPSHOT~24c817e49c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1751877929	1751877929
ci_job_id	1015336827	1015336827
ci_pipeline_id	69742479	69742479
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-su2yimw1 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-su2yimw1 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.456 s) : 15456000, 15456000
.   : milestone, 15456000,
appsec (14.693 s) : 14693000, 14693000
.   : milestone, 14693000,
iast (18.5 s) : 18500000, 18500000
.   : milestone, 18500000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
.   : milestone, 18105000,
profiling (15.173 s) : 15173000, 15173000
.   : milestone, 15173000,
tracing (14.839 s) : 14839000, 14839000
.   : milestone, 14839000,
section candidate
no_agent (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
appsec (14.77 s) : 14770000, 14770000
.   : milestone, 14770000,
iast (17.957 s) : 17957000, 17957000
.   : milestone, 17957000,
iast_GLOBAL (17.965 s) : 17965000, 17965000
.   : milestone, 17965000,
profiling (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.456 s [15.456 s, 15.456 s]	-
appsec	14.693 s [14.693 s, 14.693 s]	-763.0 ms (-4.9%)
iast	18.5 s [18.5 s, 18.5 s]	3.044 s (19.7%)
iast_GLOBAL	18.105 s [18.105 s, 18.105 s]	2.649 s (17.1%)
profiling	15.173 s [15.173 s, 15.173 s]	-283.0 ms (-1.8%)
tracing	14.839 s [14.839 s, 14.839 s]	-617.0 ms (-4.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.013 s [15.013 s, 15.013 s]	-
appsec	14.77 s [14.77 s, 14.77 s]	-243.0 ms (-1.6%)
iast	17.957 s [17.957 s, 17.957 s]	2.944 s (19.6%)
iast_GLOBAL	17.965 s [17.965 s, 17.965 s]	2.952 s (19.7%)
profiling	15.186 s [15.186 s, 15.186 s]	173.0 ms (1.2%)
tracing	15.114 s [15.114 s, 15.114 s]	101.0 ms (0.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~24c817e49c, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.411 ms) : 2362, 2461
.   : milestone, 2411,
iast (2.191 ms) : 2129, 2253
.   : milestone, 2191,
iast_GLOBAL (2.231 ms) : 2169, 2294
.   : milestone, 2231,
profiling (2.478 ms) : 2255, 2701
.   : milestone, 2478,
tracing (2.007 ms) : 1959, 2055
.   : milestone, 2007,
section candidate
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (2.401 ms) : 2352, 2450
.   : milestone, 2401,
iast (2.193 ms) : 2131, 2255
.   : milestone, 2193,
iast_GLOBAL (2.238 ms) : 2175, 2300
.   : milestone, 2238,
profiling (2.47 ms) : 2250, 2690
.   : milestone, 2470,
tracing (2.017 ms) : 1968, 2065
.   : milestone, 2017,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.411 ms [2.362 ms, 2.461 ms]	935.751 µs (63.4%)
iast	2.191 ms [2.129 ms, 2.253 ms]	714.978 µs (48.4%)
iast_GLOBAL	2.231 ms [2.169 ms, 2.294 ms]	755.341 µs (51.2%)
profiling	2.478 ms [2.255 ms, 2.701 ms]	1.002 ms (67.9%)
tracing	2.007 ms [1.959 ms, 2.055 ms]	531.131 µs (36.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.49 ms]	-
appsec	2.401 ms [2.352 ms, 2.45 ms]	922.193 µs (62.4%)
iast	2.193 ms [2.131 ms, 2.255 ms]	714.296 µs (48.3%)
iast_GLOBAL	2.238 ms [2.175 ms, 2.3 ms]	758.918 µs (51.3%)
profiling	2.47 ms [2.25 ms, 2.69 ms]	991.435 µs (67.0%)
tracing	2.017 ms [1.968 ms, 2.065 ms]	538.097 µs (36.4%)

PerfectSlayer

Looks good. Tried my best to review without running it 😅

amarziali requested review from a team as code owners July 4, 2025 15:30

amarziali requested review from ygree and PerfectSlayer and removed request for ygree July 4, 2025 15:30

amarziali added 2 commits July 7, 2025 10:09

Use runnable for callback

1c49a79

improve pipe perfs

24c817e

amarziali force-pushed the andrea.marziali/better-piped-injector branch from 5c74220 to 24c817e Compare July 7, 2025 08:10

PerfectSlayer approved these changes Jul 7, 2025

View reviewed changes

amarziali merged commit 24c817e into project/rum-injection Jul 7, 2025
302 of 326 checks passed

amarziali deleted the andrea.marziali/better-piped-injector branch July 7, 2025 08:53

PerfectSlayer added type: enhancement Enhancements and improvements comp: rum Realtime User Monitoring labels Jul 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve rum injection output stream #9107

Improve rum injection output stream #9107

Uh oh!

amarziali commented Jul 4, 2025

Uh oh!

pr-commenter bot commented Jul 4, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Uh oh!

Improve rum injection output stream #9107

Improve rum injection output stream #9107

Uh oh!

Conversation

amarziali commented Jul 4, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pr-commenter bot commented Jul 4, 2025 •

edited

Loading